Skip to content

Potential fixes for 4 code quality findings - #988

Merged
matteius merged 5 commits into
mainfrom
ai-findings-autofix/src-video-onvif_detection.c
Nov 19, 2026
Merged

matteius merged 5 commits into
mainfrom
ai-findings-autofix/src-video-onvif_detection.c

Conversation

@matteius

@matteius matteius commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Applies three safe suggestions from the code quality AI findings: serialize subscription endpoint validation with the slot lock, preserve the unmodified GetServices response for fallback parsing, and avoid logging camera URLs. The suggested release of the global registry mutex during renewal was reverted because another thread could reuse or shut down the slot while renewal was in progress. The relative request path now releases its slot lock on every return. ONVIF transport tests pass locally.

matteius and others added 5 commits November 18, 2026 23:22
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@matteius
matteius marked this pull request as ready for review November 19, 2026 04:28
@matteius
matteius merged commit 853c28b into main Nov 19, 2026
8 of 12 checks passed
@matteius
matteius deleted the ai-findings-autofix/src-video-onvif_detection.c branch November 19, 2026 04:29
@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/video/onvif_detection.c 80.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant